这是indexloc提供的服务,不要输入任何密码
Skip to content

add lazy_remove_children feature flag #7068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 22, 2024

Description

Add a feature flag to make it easy to disable lazy removal of children. Just in case I want to figure out if this is causing a specific problem in future.

Testing Instructions

Closes PACK-2269

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 3:01pm
rust-docs ❌ Failed (Inspect) Jan 22, 2024 3:01pm
turbo-site ✅ Ready (Inspect) Visit Preview Jan 22, 2024 3:01pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 3:01pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 3:01pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 3:01pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 3:01pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 3:01pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 3:01pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 3:01pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 3:01pm

Copy link
Contributor

github-actions bot commented Jan 22, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jan 22, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 1c4dc1c into main Jan 22, 2024
@sokra sokra deleted the sokra/lazy-remove-children-feature-flag branch January 22, 2024 16:30
timneutkens added a commit to vercel/next.js that referenced this pull request Jan 23, 2024
* vercel/turborepo#7067 <!-- Tobias Koppers - fix a
hanging issue with strongly consistent reads -->
* vercel/turborepo#7068 <!-- Tobias Koppers - add
lazy_remove_children feature flag -->
* vercel/turborepo#7073 <!-- OJ Kwon -
fix(ecmascript): collect recoverable error after parse -->

---------

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

Add a feature flag to make it easy to disable lazy removal of children.
Just in case I want to figure out if this is causing a specific problem
in future.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2269
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Add a feature flag to make it easy to disable lazy removal of children.
Just in case I want to figure out if this is causing a specific problem
in future.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2269
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Add a feature flag to make it easy to disable lazy removal of children.
Just in case I want to figure out if this is causing a specific problem
in future.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2269
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

Add a feature flag to make it easy to disable lazy removal of children.
Just in case I want to figure out if this is causing a specific problem
in future.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants