fix(ecmascript): collect recoverable error after parse #7073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
wbinnssmith
approved these changes
Jan 22, 2024
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
timneutkens
added a commit
to vercel/next.js
that referenced
this pull request
Jan 23, 2024
* vercel/turborepo#7067 <!-- Tobias Koppers - fix a hanging issue with strongly consistent reads --> * vercel/turborepo#7068 <!-- Tobias Koppers - add lazy_remove_children feature flag --> * vercel/turborepo#7073 <!-- OJ Kwon - fix(ecmascript): collect recoverable error after parse --> --------- Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…epo#7073) ### Description Turbopack in next.js does not report parse errors for the input like ``` function xyz() { ... ``` which expects to report ``` Expected '}', got '<eof>' ``` Comparing upstream swc, the only difference is turbopack collect recoveable error eagerly _before_ actual parsing, and then parse returns a parsed program. (ref: https://github.com/swc-project/swc/blob/979061f6babbbf855027b13eb574c5f3f7e24727/crates/swc_compiler_base/src/lib.rs#L62-L77) PR fixes ordering of error collection as same as swc does. Confirmed next.js with this change now reports expected error. (Note: doesn't mean tests are actually fixed, the output is not matching with snapshot still) Closes PACK-2274
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…epo#7073) ### Description Turbopack in next.js does not report parse errors for the input like ``` function xyz() { ... ``` which expects to report ``` Expected '}', got '<eof>' ``` Comparing upstream swc, the only difference is turbopack collect recoveable error eagerly _before_ actual parsing, and then parse returns a parsed program. (ref: https://github.com/swc-project/swc/blob/979061f6babbbf855027b13eb574c5f3f7e24727/crates/swc_compiler_base/src/lib.rs#L62-L77) PR fixes ordering of error collection as same as swc does. Confirmed next.js with this change now reports expected error. (Note: doesn't mean tests are actually fixed, the output is not matching with snapshot still) Closes PACK-2274
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…epo#7073) ### Description Turbopack in next.js does not report parse errors for the input like ``` function xyz() { ... ``` which expects to report ``` Expected '}', got '<eof>' ``` Comparing upstream swc, the only difference is turbopack collect recoveable error eagerly _before_ actual parsing, and then parse returns a parsed program. (ref: https://github.com/swc-project/swc/blob/979061f6babbbf855027b13eb574c5f3f7e24727/crates/swc_compiler_base/src/lib.rs#L62-L77) PR fixes ordering of error collection as same as swc does. Confirmed next.js with this change now reports expected error. (Note: doesn't mean tests are actually fixed, the output is not matching with snapshot still) Closes PACK-2274
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…epo#7073) ### Description Turbopack in next.js does not report parse errors for the input like ``` function xyz() { ... ``` which expects to report ``` Expected '}', got '<eof>' ``` Comparing upstream swc, the only difference is turbopack collect recoveable error eagerly _before_ actual parsing, and then parse returns a parsed program. (ref: https://github.com/swc-project/swc/blob/979061f6babbbf855027b13eb574c5f3f7e24727/crates/swc_compiler_base/src/lib.rs#L62-L77) PR fixes ordering of error collection as same as swc does. Confirmed next.js with this change now reports expected error. (Note: doesn't mean tests are actually fixed, the output is not matching with snapshot still) Closes PACK-2274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turbopack in next.js does not report parse errors for the input like
which expects to report
Comparing upstream swc, the only difference is turbopack collect recoveable error eagerly before actual parsing, and then parse returns a parsed program. (ref: https://github.com/swc-project/swc/blob/979061f6babbbf855027b13eb574c5f3f7e24727/crates/swc_compiler_base/src/lib.rs#L62-L77)
PR fixes ordering of error collection as same as swc does.
Confirmed next.js with this change now reports expected error. (Note: doesn't mean tests are actually fixed, the output is not matching with snapshot still)
Closes PACK-2274