Add yarn berry node_modules linker, CRLF/LF, and update prune #544

samchouse · 2022-01-11T14:24:34Z

closes #471
closes #536

partially fixes #237 (only node_modules linker)

Todo:

Update docs
Finish reviewing source code
Finish Yarn Berry implementation
Support CRLF on Unix and LF on Windows

What this PR brings:

Fix some typos
Add Yarn Berry support
Cleanup dead & duplicate code

Cleaning up the dead code was done by StaticCheck so if any parts of the code should be held onto for future use, I will revert that change.

vercel · 2022-01-11T14:24:39Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/5bQhp3DQBLvEcPpS3JQH8sCiS9ST
✅ Preview: https://turbo-site-git-fork-xenfo-main.vercel.sh

jaredpalmer · 2022-01-11T16:59:22Z

Looking good! Keep it going!

samchouse · 2022-01-11T18:17:24Z

@jaredpalmer I wrote an E2E test for Berry and I noticed that each time I run it, the results vary without changing files. A is impacted randomly, B is impacted randomly, sometimes not at all always with a random package manager. Is this normal?

Edit: This actually applies to all tests, running make e2e many times while changing nothing produces different results.

jaredpalmer · 2022-01-11T20:16:14Z

I noticed test flakiness over the past week or so. Haven't had a chance to look deeper

cli/internal/util/set.go

cli/internal/util/semaphore.go

samchouse · 2022-01-12T01:42:22Z

What's the point of iswin_windows.go and iswin_other.go?

cli/internal/backends/backends.go

cli/internal/backends/nodejs/nodejs.go

cli/internal/config/config.go

jaredpalmer · 2022-01-12T14:33:16Z

monorepo.linkPackages is failing in e2e for berry https://github.com/vercel/turborepo/runs/4790317239?check_suite_focus=true#step:7:73

samchouse · 2022-01-12T15:01:26Z

monorepo.linkPackages is failing in e2e for berry https://github.com/vercel/turborepo/runs/4790317239?check_suite_focus=true#step:7:73

Not sure why e2e is fine on my machine.

samchouse · 2022-01-12T18:22:05Z

I don't know how to support PNP so this PR will only fix NM linker. I saw some stuff in the install script but it doesn't seem to be working.

turbo@npm:1.0.26 couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-d56745cc/build.log)

jaredpalmer · 2022-01-12T18:27:31Z

What's the point of iswin_windows.go and iswin_other.go?

Legacy. Can be removed

cli/internal/backends/backends.go

cli/internal/backends/nodejs/nodejs.go

Co-authored-by: Jared Palmer <jared@jaredpalmer.com>

cli/internal/backends/nodejs/nodejs.go

cli/internal/context/context.go

jaredpalmer · 2022-01-14T15:54:35Z

I lied. I think we should not throw if packageManager is not defined (yet). Let's add old detection code as fallback for now and add a warning to with instructions to run "npx @turbo/migrate add-package-manager"

samchouse · 2022-01-14T16:29:32Z

How do I issue a warning?

jaredpalmer · 2022-01-14T17:04:22Z

logWarning() or log.Println("[WARNING] ...")

samchouse · 2022-01-14T18:23:29Z

Where do I get those functions? Do I warn in nodejs.go or run.go, etc.?

samchouse · 2022-01-20T15:25:49Z

@jaredpalmer Still not sure how to warn from the backend file.

jaredpalmer · 2022-01-20T15:27:25Z

log is a standard Go package https://pkg.go.dev/log

samchouse · 2022-01-21T15:35:56Z

Sorry, it wasn't printing anything before 😅

vercel bot deployed to Preview January 11, 2022 14:24 View deployment

vercel bot deployed to Preview January 11, 2022 15:03 View deployment

vercel bot deployed to Preview January 11, 2022 17:35 View deployment

vercel bot deployed to Preview January 11, 2022 18:24 View deployment

vercel bot deployed to Preview January 11, 2022 19:50 View deployment

jaredpalmer suggested changes Jan 11, 2022

View reviewed changes

cli/internal/util/set.go Outdated Show resolved Hide resolved

cli/internal/util/semaphore.go Outdated Show resolved Hide resolved

vercel bot deployed to Preview January 11, 2022 21:07 View deployment

vercel bot deployed to Preview January 12, 2022 01:57 View deployment

samchouse changed the title ~~fix: cleanup + yarn berry~~ fix: qol + cleanup + yarn berry Jan 12, 2022

vercel bot deployed to Preview January 12, 2022 14:01 View deployment

jaredpalmer suggested changes Jan 12, 2022

View reviewed changes

cli/internal/backends/backends.go Outdated Show resolved Hide resolved

cli/internal/backends/nodejs/nodejs.go Outdated Show resolved Hide resolved

cli/internal/config/config.go Outdated Show resolved Hide resolved

cli/internal/config/config.go Outdated Show resolved Hide resolved

vercel bot deployed to Preview January 12, 2022 14:49 View deployment

vercel bot deployed to Preview January 12, 2022 14:59 View deployment

vercel bot deployed to Preview January 12, 2022 15:54 View deployment

samchouse requested a review from jaredpalmer January 12, 2022 15:54

vercel bot deployed to Preview January 12, 2022 15:56 View deployment

vercel bot deployed to Preview January 12, 2022 18:00 View deployment

vercel bot deployed to Preview January 12, 2022 18:37 View deployment

jaredpalmer suggested changes Jan 12, 2022

View reviewed changes

cli/internal/backends/backends.go Outdated Show resolved Hide resolved

samchouse requested a review from jaredpalmer January 12, 2022 19:00

vercel bot deployed to Preview January 12, 2022 19:00 View deployment

Merge branch 'main' into main

138066e

vercel bot deployed to Preview January 13, 2022 18:53 View deployment

jaredpalmer reviewed Jan 13, 2022

View reviewed changes

cli/internal/backends/nodejs/nodejs.go Outdated Show resolved Hide resolved

Update cli/internal/backends/nodejs/nodejs.go

d85b787

Co-authored-by: Jared Palmer <jared@jaredpalmer.com>

vercel bot deployed to Preview January 13, 2022 19:16 View deployment

jaredpalmer suggested changes Jan 13, 2022

View reviewed changes

Update cli/internal/backends/nodejs/nodejs.go

21a4ca3

vercel bot deployed to Preview January 13, 2022 19:28 View deployment

jaredpalmer added 4 commits January 13, 2022 14:28

Update cli/internal/backends/nodejs/nodejs.go

ef5d3be

Update cli/internal/backends/nodejs/nodejs.go

b1df6d1

Update cli/internal/context/context.go

883efe8

Update cli/internal/backends/nodejs/nodejs.go

1b49254

vercel bot deployed to Preview January 13, 2022 19:29 View deployment

jaredpalmer changed the title ~~fix: yarn berry node_modules linker, CRLF/LF, and prune~~ Add yarn berry node_modules linker, CRLF/LF, and prune Jan 13, 2022

jaredpalmer changed the title ~~Add yarn berry node_modules linker, CRLF/LF, and prune~~ Add yarn berry node_modules linker, CRLF/LF, and update prune Jan 13, 2022

vercel bot deployed to Preview January 13, 2022 20:22 View deployment

jaredpalmer mentioned this pull request Jan 13, 2022

Add @turbo/codemod package #556

Merged

2 tasks

jaredpalmer merged commit 6a5d70e into vercel:main Jan 14, 2022

samchouse mentioned this pull request Jan 14, 2022

feat: move lockfile logic into backends #560

Closed

jaredpalmer mentioned this pull request Jan 20, 2022

Fix ./scripts/check-examples.sh to handle canary #577

Closed

samchouse mentioned this pull request Jan 21, 2022

fix: warn when no packageManager #579

Merged

b12k mentioned this pull request Jan 25, 2022

Windows & Yarn - prunning fails with could not construct graph error #600

Closed

Add yarn berry node_modules linker, CRLF/LF, and update prune #544

Add yarn berry node_modules linker, CRLF/LF, and update prune #544

Uh oh!

Conversation

samchouse commented Jan 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo:

What this PR brings:

Uh oh!

vercel bot commented Jan 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaredpalmer commented Jan 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samchouse commented Jan 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaredpalmer commented Jan 11, 2022

Uh oh!

Uh oh!

Uh oh!

samchouse commented Jan 12, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaredpalmer commented Jan 12, 2022

Uh oh!

samchouse commented Jan 12, 2022

Uh oh!

samchouse commented Jan 12, 2022

Uh oh!

jaredpalmer commented Jan 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaredpalmer commented Jan 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samchouse commented Jan 14, 2022

Uh oh!

jaredpalmer commented Jan 14, 2022

Uh oh!

samchouse commented Jan 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samchouse commented Jan 20, 2022

Uh oh!

jaredpalmer commented Jan 20, 2022

Uh oh!

samchouse commented Jan 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

samchouse commented Jan 11, 2022 •

edited

Loading

vercel bot commented Jan 11, 2022 •

edited

Loading

jaredpalmer commented Jan 11, 2022 •

edited

Loading

samchouse commented Jan 11, 2022 •

edited

Loading

jaredpalmer commented Jan 12, 2022 •

edited

Loading

jaredpalmer commented Jan 14, 2022 •

edited

Loading

samchouse commented Jan 14, 2022 •

edited

Loading