这是indexloc提供的服务,不要输入任何密码
Skip to content

Running turbo on a yarn lock file with LF ending on Windows causes a marshal error #471

@vladfrangu

Description

@vladfrangu

What version of Turborepo are you using?

1.0.24-canary.2

What package manager are you using / does the bug impact?

Yarn v1

What operating system are you using?

Windows

Describe the Bug

With #434, there was a bug that was fixed about reading lock files, however it seems that they didn't account for users that use LF endings on Windows (either by manually converting it to LF, or by committing the lock file with git with a forced LF setting), which causes turbo to hard crash with the following error:

yarn run v1.22.15
$ turbo run lint --cache-dir=.turbo
 ERROR  yarn.lock: could not unmarshal lockfile: yaml: unmarshal errors:
  line 5: cannot unmarshal !!str `@babel/...` into fs.YarnLockfile
node:child_process:867
    throw err;
    ^

Error: Command failed: F:\Development\Discord\discord.js\node_modules\turbo-windows-64\turbo.exe run lint --cache-dir=.turbo
    at checkExecSyncError (node:child_process:826:11)
    at Object.execFileSync (node:child_process:864:15)
    at Object.<anonymous> (F:\Development\Discord\discord.js\node_modules\turbo\bin\turbo:5:26)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47 {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 2456,
  stdout: null,
  stderr: null
}

Expected Behavior

Turbo should be able to handle both CRLF and LF endings, no matter the operating system it's ran on

To Reproduce

Generate a yarn.lock file on Windows
Change it's line endings to LF (manually via an editor like VSCode, or through git)
Attempt to run any turbo scripts

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: windowsIssues specifically reproducing on Windowskind: bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions