-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: move lockfile logic into backends #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/5e8hrGBitVJG4rU1cN8VVZGVJhCW |
So my thinking is that each backend should be responsible / have a function for resolving a given package's external dependencies (out of the backend's lockfile) in an abstracted manner so that the implementation details of the backend leaked into |
I'm a bit confused with what you want. I have it so that it goes through the keys each backend provides (only yarn and yarn berry is supported so the other backends have empty arrays) and gets the lockfile entry. Do you want it to resolve the entry in the backend and not in context? |
@jaredpalmer I need further guidance on this. |
@xenfo IIUC, the idea would be to remove usages of |
@xenfo is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Are you still working on this? |
Yeah I'll try to finish it this weekend. |
@jaredpalmer I took a look, and I'm not sure how to move it, some things are |
Related:
What this PR brings:
This PR moves lockfile logic out of
context.go
and into it's specific backend as per #544 (comment).