这是indexloc提供的服务,不要输入任何密码
Skip to content

feat: move lockfile logic into backends #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

feat: move lockfile logic into backends #560

wants to merge 22 commits into from

Conversation

samchouse
Copy link
Contributor

@samchouse samchouse commented Jan 14, 2022

Related:

What this PR brings:

This PR moves lockfile logic out of context.go and into it's specific backend as per #544 (comment).

@vercel
Copy link

vercel bot commented Jan 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/5e8hrGBitVJG4rU1cN8VVZGVJhCW
✅ Preview: https://turbo-site-git-fork-xenfo-feat-lockfile-context-logic.vercel.sh

@jaredpalmer
Copy link
Contributor

So my thinking is that each backend should be responsible / have a function for resolving a given package's external dependencies (out of the backend's lockfile) in an abstracted manner so that the implementation details of the backend leaked into context.go.

@samchouse
Copy link
Contributor Author

samchouse commented Jan 14, 2022

I'm a bit confused with what you want. I have it so that it goes through the keys each backend provides (only yarn and yarn berry is supported so the other backends have empty arrays) and gets the lockfile entry. Do you want it to resolve the entry in the backend and not in context?

@samchouse
Copy link
Contributor Author

I'm a bit confused with what you want. I have it so that it goes through the keys each backend provides (only yarn and yarn berry is supported so the other backends have empty arrays) and gets the lockfile entry. Do you want it to resolve the entry in the backend and not in context?

@jaredpalmer I need further guidance on this.

@gsoltis
Copy link
Contributor

gsoltis commented Feb 28, 2022

@xenfo IIUC, the idea would be to remove usages of util.IsYarn from context.go and instead have the relevant functionality baked into the backend.

@vercel
Copy link

vercel bot commented Mar 7, 2022

@xenfo is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@jaredpalmer
Copy link
Contributor

Are you still working on this?

@samchouse
Copy link
Contributor Author

Yeah I'll try to finish it this weekend.

@samchouse
Copy link
Contributor Author

samchouse commented Mar 19, 2022

@jaredpalmer I took a look, and I'm not sure how to move it, some things are context specific.

@samchouse samchouse closed this Sep 12, 2022
@samchouse samchouse deleted the feat/lockfile-context-logic branch September 12, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants