这是indexloc提供的服务，不要输入任何密码
Skip to content

QoL changes for using examples #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 10, 2022
Merged

QoL changes for using examples #518

merged 10 commits into from
Jan 10, 2022

Conversation

@markjm
Copy link
Contributor

@markjm markjm commented Jan 7, 2022

  1. Always use the locally built turbo binary to support easier usage within the examples. Similar to how it is done in the run-examples script, but for local use as well.
  2. differentiate logged output when cache is missed vs when execution is forced
  3. Hide the big error object from printing to console when execution fails. See before and after
    image
    Not sure what the thinking is on what else to write out on failure, but i suspect whatever message should come from the main turborepo program and not the node wrapper.

Loving digging around the project! Feel free to accept or reject any number of pieces of this changeset.

@markjm markjm requested a review from jaredpalmer as a code owner January 7, 2022 02:25
@vercel
Copy link
Contributor

vercel bot commented Jan 7, 2022

@markjm is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Contributor

vercel bot commented Jan 7, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/Dw8vaw5qWTTWfjX3RK2GZxXSYaPy
✅ Preview: https://turbo-site-git-fork-markjm-markjm-clean-error.vercel.sh

@markjm
Copy link
Contributor Author

markjm commented Jan 9, 2022

I have actually identified an issue when running a fresh yarn install with TURBO_BINARY_PATH set. Seems to be because of differences in directories when running the postinstall script vs an actual turbo command - which prevents using a relative path in yarnrc

@jaredpalmer
Copy link
Contributor

jaredpalmer commented Jan 10, 2022

Why do we need .yarnc?

@markjm
Copy link
Contributor Author

markjm commented Jan 10, 2022

Why do we need .yarnc?

the intent is that regardless of platform or mode of running the examples, it will always use the repo-built version of the app by having this univeral way of specifying process.env varialbes. Given there are some other differences with usage of that env variable (and now thinking i dont know if pnmp or other backends would even support this), I will remove that change to unblock the rest of the PR

@jaredpalmer
Copy link
Contributor

jaredpalmer commented Jan 10, 2022

In the future, these should likely be separate PRs, but other than that this looks fine. Thanks!

@jaredpalmer jaredpalmer added the pr: automerge Kodiak will merge these automatically after checks pass label Jan 10, 2022
@markjm
Copy link
Contributor Author

markjm commented Jan 10, 2022

In the future, these should likely be separate PRs, but other than that this looks fine. Thanks!

Fair - thanks for the help

@jaredpalmer jaredpalmer merged commit ad6c5d9 into vercel:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jaredpalmer jaredpalmer jaredpalmer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: automerge Kodiak will merge these automatically after checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markjm @jaredpalmer