这是indexloc提供的服务，不要输入任何密码
Skip to content

QoL changes for using examples #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 10, 2022
Merged

QoL changes for using examples #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
46d0e0d
QoL changes for using examples
Jan 7, 2022
0fbe5dc
Merge branch 'main' into markjm/clean-error
jaredpalmer Jan 7, 2022
d0fcb35
Update cache bypass log
jaredpalmer Jan 7, 2022
9728405
Merge branch 'main' into markjm/clean-error
jaredpalmer Jan 7, 2022
5fd8604
Merge branch 'main' into markjm/clean-error
jaredpalmer Jan 10, 2022
1bdd099
Merge branch 'main' into markjm/clean-error
jaredpalmer Jan 10, 2022
64df51f
remove yarnrc
Jan 10, 2022
53f1992
Fix Ken's twitter handle
Jan 10, 2022
13aa965
Merge branch 'main' into markjm/clean-error
jaredpalmer Jan 10, 2022
4aa5441
Merge branch 'main' into markjm/clean-error
jaredpalmer Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions cli/internal/run/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,7 @@ func (c *RunCommand) Run(args []string) int {

// Cache ---------------------------------------------
var hit bool
if runOptions.forceExecution {
hit = false
} else {
if !runOptions.forceExecution {
hit, _, err = turboCache.Fetch(pack.Dir, hash, nil)
if err != nil {
targetUi.Error(fmt.Sprintf("error fetching from cache: %s", err))
Expand All @@ -461,10 +459,13 @@ func (c *RunCommand) Run(args []string) int {

return nil
}
}

if runOptions.stream {
targetUi.Output(fmt.Sprintf("cache miss, executing %s", ui.Dim(hash)))
if runOptions.stream {
targetUi.Output(fmt.Sprintf("cache miss, executing %s", ui.Dim(hash)))
}
} else {
if runOptions.stream {
targetUi.Output(fmt.Sprintf("cache bypass, force executing %s", ui.Dim(hash)))
}
}

// Setup command execution
Expand Down
15 changes: 10 additions & 5 deletions cli/npm/turbo-install/bin/turbo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,13 @@

const { generateBinPath } = require("../node-platform");

require("child_process").execFileSync(
generateBinPath(),
process.argv.slice(2),
{ stdio: "inherit" }
);
try {
require("child_process").execFileSync(
generateBinPath(),
process.argv.slice(2),
{ stdio: "inherit" }
);
} catch(e) {
if(e && e.status) process.exit(e.status);
throw e;
}
2 changes: 1 addition & 1 deletion docs/pages/docs/acknowledgments.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ Additionally, we're grateful to:

- [Rick Button](https://twitter.com/rickbutton) for donating the `turbo` package name on NPM
- [Iheanyi Ekechukwu](https://twitter.com/kwuchu) for helping Jared pick up Golang during the Pandemic!
- [Kenneth Chau](https://twitter.com/kennethchau) for Lage's Scope and Pipeline API and docs
- [Kenneth Chau](https://twitter.com/kenneth_chau) for Lage's Scope and Pipeline API and docs
- [Miguel Oller](https://mobile.twitter.com/ollermi) and [MakeSwift.com](https://makeswift.com) for piloting Turbo
- [Eric Koslow](https://twitter.com/ekosz1), [Jack Hanford](https://twitter.com/jackhanford), and [Lattice.com](https://lattice.com) for piloting Turbo