fix: Move runOptions stream checks before the for loop to prevent cpu load
#529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`runOptions.stream` is now `true` by default, so `Listen` now performs a lot of empty runs, causing cpu load (one core having 100% load all the time). This fix prevents the overload by never running the loop if `stream` is set to `true`, as all cases in the loop relied on it being false.
|
@marcinbunsch is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Closed
jaredpalmer
previously approved these changes
Jan 10, 2022
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/2J7avyGTXDt2j7FHmxoChxg3rLeR |
jaredpalmer
approved these changes
Jan 10, 2022
for loop to prevent cpu loadfor loop to prevent cpu load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runOptions.streamis nowtrueby default, soListennow performsa lot of empty runs, causing cpu load (one core having 100% load all the time).
This fix prevents the overload by never running the loop if
streamis setto
true, as all cases in the loop relied on it being false.I left a bunch of debugging notes here: #205 (comment)
Should solve these two issues:
Fix #205
Fix #521