这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: Move runOptions stream checks before the for loop to prevent cpu load #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2022
Merged

fix: Move runOptions stream checks before the for loop to prevent cpu load #529

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b3a915
Move runOptions stream checks before the `for` loop to prevent cpu load
marcinbunsch Jan 9, 2022
f7f8287
Merge branch 'main' into main
jaredpalmer Jan 10, 2022
00053a6
Merge branch 'main' into main
jaredpalmer Jan 10, 2022
67426c9
Only setup channel and ticker when not streaming (buck output)
jaredpalmer Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions cli/internal/run/run_state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,14 @@ type RunState struct {

func NewRunState(runOptions *RunOptions) *RunState {
return &RunState{
Success: 0,
Failure: 0,
Cached: 0,
Attempted: 0,
state: make(map[string]*BuildTargetState),
done: make(chan string),
Success: 0,
Failure: 0,
Cached: 0,
Attempted: 0,
state: make(map[string]*BuildTargetState),

cursor: cursor.New(),
runOptions: runOptions,
ticker: time.NewTicker(100 * time.Millisecond),
}
}

Expand Down Expand Up @@ -200,6 +199,11 @@ func (r *RunState) add(result *RunResult, previous string, active bool) {
}

func (r *RunState) Listen(Ui cli.Ui, startAt time.Time) {
if r.runOptions.stream {
return
}
r.ticker = time.NewTicker(100 * time.Millisecond)
r.done = make(chan string)
lineBuffer := 10
go func(r *RunState, Ui cli.Ui) {
z := r
Expand Down Expand Up @@ -290,8 +294,12 @@ func (r *RunState) Close(Ui cli.Ui, startAt time.Time, filename string) error {
return err
}
}
r.ticker.Stop()
r.done <- "done"

if !r.runOptions.stream {
r.ticker.Stop()
r.done <- "done"
}

maybeFullTurbo := ""
if r.Cached == r.Attempted {
maybeFullTurbo = ui.Rainbow(">>> FULL TURBO")
Expand Down