swap out log for tracing and add the TurboFormatter #4694
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
tknickman
left a comment
There was a problem hiding this comment.
Nice, looks good to me - I'll let a rust pro check it out but nothing blocking from my end
🟢 CI successful 🟢Thanks |
c132e9e to
00ae70e
Compare
mehulkar
left a comment
There was a problem hiding this comment.
What did you mean by "facade" in the PR description? Are we planning to invoke Rust to log things from Go land?
| }); | ||
|
|
||
| builder.init(); | ||
| // respect TURBO_LOG_VERBOSITY env var |
There was a problem hiding this comment.
is this new? i didn't know this was a thing
There was a problem hiding this comment.
All I mean is that tracing lets you output logs to a bunch of different places; stdout, files, opentelemetry and even chrome tracing through the same logging / span infrastructure :)
There was a problem hiding this comment.
Our default 'subscriber' is one that prints to stdout following the same format as our go code.
This allows us to switch out facades when needed and sets up a default facade for stdout that follows the current formatting for turbo which is to simply ignore all event fields except the message
00ae70e to
6824483
Compare
249a0fb to
d4893c5
Compare
This allows us to switch out facades when needed and sets up a default facade for stdout that follows the current formatting for turbo which is to simply ignore all event fields except the message.
The output format is identical.