swap out log for tracing and add the TurboFormatter #4694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
tknickman
reviewed
Apr 25, 2023
🟢 CI successful 🟢Thanks |
c132e9e to
00ae70e
Compare
mehulkar
approved these changes
Apr 27, 2023
| }); | ||
|
|
||
| builder.init(); | ||
| // respect TURBO_LOG_VERBOSITY env var |
There was a problem hiding this comment.
is this new? i didn't know this was a thing
There was a problem hiding this comment.
All I mean is that tracing lets you output logs to a bunch of different places; stdout, files, opentelemetry and even chrome tracing through the same logging / span infrastructure :)
There was a problem hiding this comment.
Our default 'subscriber' is one that prints to stdout following the same format as our go code.
This allows us to switch out facades when needed and sets up a default facade for stdout that follows the current formatting for turbo which is to simply ignore all event fields except the message
00ae70e to
6824483
Compare
249a0fb to
d4893c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to switch out facades when needed and sets up a default facade for stdout that follows the current formatting for turbo which is to simply ignore all event fields except the message.
The output format is identical.