这是indexloc提供的服务，不要输入任何密码
Skip to content

Alias next/dynamic to React.lazy implementation for RSC #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

Alias next/dynamic to React.lazy implementation for RSC #3188

merged 1 commit into from
Jan 12, 2023

Conversation

alexkirsz
Copy link
Contributor

No description provided.

@alexkirsz alexkirsz requested a review from a team as a code owner January 5, 2023 14:39
@vercel
Copy link

vercel bot commented Jan 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

10 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 1:34PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 1:34PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 12, 2023 at 1:34PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 12, 2023 at 1:34PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 1:34PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 12, 2023 at 1:34PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 1:34PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 1:34PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2023 at 1:34PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 1:34PM (UTC)

This was referenced Jan 5, 2023
Merged
Merged
@alexkirsz
Copy link
Contributor Author

alexkirsz commented Jan 5, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alexkirsz alexkirsz mentioned this pull request Jan 6, 2023
Merged
@alexkirsz alexkirsz force-pushed the alexkirsz/web-375-apply-the-nextdynamic-swc-transform branch from a661cdd to 468260f Compare January 6, 2023 09:14
alexkirsz
alexkirsz commented Jan 6, 2023
View reviewed changes
crates/next-core/src/next_import_map.rs
"react-dom/",
request_to_import_mapping(app_dir, "next/dist/compiled/react-dom/*"),
);
alias_next_dynamic_to_react_lazy_for_rsc(&mut import_map, app_dir);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only semantic change.

@alexkirsz alexkirsz force-pushed the alexkirsz/web-376-alias-nextdynamic-to-reactlazy branch from 65fa4ba to eacc1b8 Compare January 6, 2023 09:19
@alexkirsz alexkirsz force-pushed the alexkirsz/web-375-apply-the-nextdynamic-swc-transform branch from 468260f to a4c98cd Compare January 9, 2023 12:36
@alexkirsz alexkirsz requested a review from a team as a code owner January 9, 2023 12:36
@alexkirsz alexkirsz requested review from tknickman and chris-olszewski and removed request for a team January 9, 2023 12:36
@alexkirsz alexkirsz force-pushed the alexkirsz/web-376-alias-nextdynamic-to-reactlazy branch from eacc1b8 to 6dd3587 Compare January 9, 2023 12:36
@alexkirsz alexkirsz force-pushed the alexkirsz/web-375-apply-the-nextdynamic-swc-transform branch from a4c98cd to 44ca034 Compare January 9, 2023 13:12
@alexkirsz alexkirsz force-pushed the alexkirsz/web-376-alias-nextdynamic-to-reactlazy branch from 6dd3587 to c0fc76d Compare January 9, 2023 13:12
@alexkirsz alexkirsz force-pushed the alexkirsz/web-375-apply-the-nextdynamic-swc-transform branch from 44ca034 to c9f8a3f Compare January 10, 2023 16:16
@alexkirsz alexkirsz force-pushed the alexkirsz/web-376-alias-nextdynamic-to-reactlazy branch from c0fc76d to 883f9da Compare January 10, 2023 16:16
@alexkirsz alexkirsz force-pushed the alexkirsz/web-375-apply-the-nextdynamic-swc-transform branch from c9f8a3f to 0131667 Compare January 11, 2023 12:39
@alexkirsz alexkirsz force-pushed the alexkirsz/web-376-alias-nextdynamic-to-reactlazy branch from 883f9da to c7984a0 Compare January 11, 2023 12:39
@alexkirsz alexkirsz force-pushed the alexkirsz/web-375-apply-the-nextdynamic-swc-transform branch from 0131667 to 9db4af2 Compare January 11, 2023 12:59
@alexkirsz alexkirsz force-pushed the alexkirsz/web-376-alias-nextdynamic-to-reactlazy branch from c7984a0 to b00c85c Compare January 11, 2023 12:59
@alexkirsz alexkirsz force-pushed the alexkirsz/web-375-apply-the-nextdynamic-swc-transform branch from 9db4af2 to faf449f Compare January 12, 2023 11:18
@alexkirsz alexkirsz force-pushed the alexkirsz/web-376-alias-nextdynamic-to-reactlazy branch 2 times, most recently from af9aa97 to 437d341 Compare January 12, 2023 11:23
@alexkirsz alexkirsz force-pushed the alexkirsz/web-375-apply-the-nextdynamic-swc-transform branch from 8dd98aa to 28ad87a Compare January 12, 2023 11:28
@alexkirsz alexkirsz force-pushed the alexkirsz/web-376-alias-nextdynamic-to-reactlazy branch from 437d341 to 86aa4f9 Compare January 12, 2023 11:28
@alexkirsz alexkirsz force-pushed the alexkirsz/web-375-apply-the-nextdynamic-swc-transform branch from 28ad87a to 19480dc Compare January 12, 2023 12:06
@alexkirsz alexkirsz force-pushed the alexkirsz/web-376-alias-nextdynamic-to-reactlazy branch from 86aa4f9 to fc28e12 Compare January 12, 2023 12:06
@alexkirsz alexkirsz force-pushed the alexkirsz/web-375-apply-the-nextdynamic-swc-transform branch from 19480dc to 183d30f Compare January 12, 2023 13:33
@alexkirsz alexkirsz force-pushed the alexkirsz/web-376-alias-nextdynamic-to-reactlazy branch from fc28e12 to 60744c5 Compare January 12, 2023 13:33
@alexkirsz alexkirsz merged commit 58a14a7 into alexkirsz/web-375-apply-the-nextdynamic-swc-transform Jan 12, 2023
@alexkirsz alexkirsz deleted the alexkirsz/web-376-alias-nextdynamic-to-reactlazy branch January 12, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman was automatically assigned from vercel/turbo-oss

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski was automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexkirsz @wbinnssmith