这是indexloc提供的服务，不要输入任何密码
Skip to content

Reorganize next_client and next_server modules #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2023
Merged

Reorganize next_client and next_server modules #3182

merged 1 commit into from
Jan 6, 2023

Conversation

alexkirsz
Copy link
Contributor

This is a straightforward chore PR to move next_client and next_server modules
around, in order to make navigation and imports more predictable between them.

I'm also planning to introduce a next_shared::context in a further PR, hence the
changes.

@alexkirsz alexkirsz requested a review from a team as a code owner January 5, 2023 09:49
@vercel
Copy link

vercel bot commented Jan 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web 🔄 Building (Inspect) Jan 6, 2023 at 9:15AM (UTC)
examples-cra-web 🔄 Building (Inspect) Jan 6, 2023 at 9:15AM (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Jan 6, 2023 at 9:15AM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 6, 2023 at 9:15AM (UTC)
6 Ignored Deployments
Name Status Preview Comments Updated
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 6, 2023 at 9:15AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 6, 2023 at 9:15AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 6, 2023 at 9:15AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 6, 2023 at 9:15AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 6, 2023 at 9:15AM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 6, 2023 at 9:15AM (UTC)

@alexkirsz
Copy link
Contributor Author

alexkirsz commented Jan 5, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alexkirsz alexkirsz force-pushed the alexkirsz/web-374-re-organize-next_client-and-next_server branch from c2118c4 to a6720b1 Compare January 5, 2023 10:28
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Benchmark for 923e1a2

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7919.82µs ± 26.76µs 7916.14µs ± 50.50µs -0.05%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8180.82µs ± 40.53µs 8152.15µs ± 47.52µs -0.35%
bench_hmr_to_commit/Turbopack RSC/1000 modules 460.61ms ± 1.90ms 462.42ms ± 1.78ms +0.39%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8124.49µs ± 70.99µs 8103.46µs ± 56.62µs -0.26%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7017.83µs ± 41.37µs 7010.74µs ± 38.59µs -0.10%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7165.00µs ± 67.04µs 7114.51µs ± 43.28µs -0.70%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7124.95µs ± 28.20µs 7098.30µs ± 57.13µs -0.37%
bench_hydration/Turbopack RCC/1000 modules 3264.26ms ± 9.36ms 3295.88ms ± 8.73ms +0.97%
bench_hydration/Turbopack RSC/1000 modules 2764.40ms ± 9.79ms 2758.29ms ± 5.80ms -0.22%
bench_hydration/Turbopack SSR/1000 modules 2578.56ms ± 12.11ms 2591.15ms ± 8.75ms +0.49%
bench_startup/Turbopack CSR/1000 modules 1609.37ms ± 3.00ms 1600.82ms ± 5.81ms -0.53%
bench_startup/Turbopack RCC/1000 modules 2458.93ms ± 7.57ms 2451.22ms ± 6.91ms -0.31%
bench_startup/Turbopack RSC/1000 modules 2378.91ms ± 6.21ms 2367.82ms ± 6.99ms -0.47%
bench_startup/Turbopack SSR/1000 modules 2004.53ms ± 5.43ms 2010.04ms ± 6.05ms +0.28%

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@alexkirsz alexkirsz force-pushed the alexkirsz/web-374-re-organize-next_client-and-next_server branch from a6720b1 to ccfa77b Compare January 5, 2023 13:03
@alexkirsz alexkirsz mentioned this pull request Jan 5, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Benchmark for 4495cc2

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7998.18µs ± 61.05µs 7963.60µs ± 40.80µs -0.43%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8261.10µs ± 30.94µs 8361.74µs ± 56.28µs +1.22%
bench_hmr_to_commit/Turbopack RSC/1000 modules 482.09ms ± 1.86ms 473.92ms ± 2.76ms -1.69%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8060.01µs ± 60.90µs 8100.75µs ± 53.93µs +0.51%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7060.33µs ± 54.11µs 7051.28µs ± 59.59µs -0.13%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7166.24µs ± 86.48µs 7196.45µs ± 60.58µs +0.42%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7131.83µs ± 20.23µs 7105.62µs ± 59.79µs -0.37%
bench_hydration/Turbopack RCC/1000 modules 3302.26ms ± 11.28ms 3323.14ms ± 15.79ms +0.63%
bench_hydration/Turbopack RSC/1000 modules 2829.78ms ± 6.60ms 2821.97ms ± 8.98ms -0.28%
bench_hydration/Turbopack SSR/1000 modules 2652.62ms ± 7.32ms 2646.13ms ± 9.27ms -0.24%
bench_startup/Turbopack CSR/1000 modules 1638.61ms ± 4.26ms 1645.18ms ± 4.07ms +0.40%
bench_startup/Turbopack RCC/1000 modules 2522.03ms ± 9.45ms 2538.05ms ± 11.11ms +0.64%
bench_startup/Turbopack RSC/1000 modules 2427.46ms ± 8.70ms 2421.68ms ± 3.40ms -0.24%
bench_startup/Turbopack SSR/1000 modules 2068.90ms ± 6.15ms 2070.79ms ± 4.64ms +0.09%

@alexkirsz alexkirsz mentioned this pull request Jan 5, 2023
Merged
@alexkirsz alexkirsz mentioned this pull request Jan 6, 2023
Merged
@alexkirsz alexkirsz force-pushed the alexkirsz/web-374-re-organize-next_client-and-next_server branch from ccfa77b to 9f0b183 Compare January 6, 2023 09:14
@alexkirsz alexkirsz added the pr: automerge Kodiak will merge these automatically after checks pass label Jan 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Benchmark for 44aaff4

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8674.06µs ± 78.37µs 8674.48µs ± 60.21µs +0.00%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8978.71µs ± 53.97µs 8967.37µs ± 63.50µs -0.13%
bench_hmr_to_commit/Turbopack RSC/1000 modules 479.89ms ± 2.43ms 478.15ms ± 1.56ms -0.36%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8718.34µs ± 67.51µs 8814.68µs ± 68.15µs +1.11%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7647.91µs ± 31.13µs 7708.16µs ± 47.90µs +0.79%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7779.83µs ± 48.82µs 7769.76µs ± 82.77µs -0.13%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7751.53µs ± 80.50µs 7748.81µs ± 62.47µs -0.04%
bench_hydration/Turbopack RCC/1000 modules 3355.61ms ± 8.59ms 3362.47ms ± 6.96ms +0.20%
bench_hydration/Turbopack RSC/1000 modules 2832.97ms ± 6.14ms 2842.85ms ± 6.32ms +0.35%
bench_hydration/Turbopack SSR/1000 modules 2661.86ms ± 9.77ms 2674.74ms ± 13.62ms +0.48%
bench_startup/Turbopack CSR/1000 modules 1674.76ms ± 7.65ms 1665.01ms ± 3.42ms -0.58%
bench_startup/Turbopack RCC/1000 modules 2558.69ms ± 7.32ms 2546.75ms ± 7.27ms -0.47%
bench_startup/Turbopack RSC/1000 modules 2432.06ms ± 6.66ms 2443.66ms ± 9.75ms +0.48%
bench_startup/Turbopack SSR/1000 modules 2084.03ms ± 4.37ms 2074.87ms ± 4.78ms -0.44%

@kodiakhq kodiakhq bot merged commit 86474aa into main Jan 6, 2023
@kodiakhq kodiakhq bot deleted the alexkirsz/web-374-re-organize-next_client-and-next_server branch January 6, 2023 10:36
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@alexkirsz
Reorganize next_client and next_server modules (vercel/turborepo#3182)
96d04d3 
This is a straightforward chore PR to move next_client and next_server modules
around, in order to make navigation and imports more predictable between them.

I'm also planning to introduce a next_shared::context in a further PR, hence the
changes.
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@alexkirsz
Reorganize next_client and next_server modules (vercel/turborepo#3182)
d79c929 
This is a straightforward chore PR to move next_client and next_server modules
around, in order to make navigation and imports more predictable between them.

I'm also planning to introduce a next_shared::context in a further PR, hence the
changes.
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@alexkirsz
Reorganize next_client and next_server modules (vercel/turborepo#3182)
0e9c617 
This is a straightforward chore PR to move next_client and next_server modules
around, in order to make navigation and imports more predictable between them.

I'm also planning to introduce a next_shared::context in a further PR, hence the
changes.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@alexkirsz
Reorganize next_client and next_server modules (vercel/turborepo#3182)
eacab32 
This is a straightforward chore PR to move next_client and next_server modules
around, in order to make navigation and imports more predictable between them.

I'm also planning to introduce a next_shared::context in a further PR, hence the
changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexkirsz @wbinnssmith