Remove default task outputs when outputs is not defined #2712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
This behavior is frameworks-specific and unintuitive to new users. Specifically, this removes the confusion between omitting the outputs key and setting to an empty array. Additionally, this will allow us to more clearly define turbo.json composition, so locally-scoped turbo.json configs can override outputs, without rationalizing what happens to this implicit behavior.
🟢 CI successful 🟢Thanks |
a9ea366 to
6ea1478
Compare
|
This will require a turbo codemod. |
yep, separate PR, but will land before 1.7 is released |
nathanhammond
approved these changes
Nov 16, 2022
| @@ -21,8 +21,6 @@ const ( | |||
| topologicalPipelineDelimiter = "^" | |||
| ) | |||
|
|
|||
| var defaultOutputs = TaskOutputs{Inclusions: []string{"dist/**/*", "build/**/*"}} | |||
There was a problem hiding this comment.
I'm like 99.999% confident that dist/**/* and dist/** are equivalent in doublestar, but I'd love to be 100% sure. Can you triple-check that for us?
There was a problem hiding this comment.
I'll just fix the codemod to use the same glob as here :)
tknickman
pushed a commit
that referenced
this pull request
Jan 10, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is frameworks-specific and unintuitive to new users.
Specifically, this removes the confusion between omitting the outputs
key and setting to an empty array. Additionally, this will allow us to
more clearly define turbo.json composition, so locally-scoped turbo.json
configs can override outputs, without rationalizing what happens to this
implicit behavior.
Stacked PRs:
turbo@1.7