这是indexloc提供的服务,不要输入任何密码
Skip to content

Remove hard link code and SameFile function #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Jun 28, 2022

Removes code for hard links, which wasn't being used. Removes CopyOrLinkFile, which means symlink handling needs to be pushed down to CopyFile, so CopyFile now handles symlinks (broken or otherwise). Caching behavior is unchanged from the base branch (See #1453).

Also removes SameFile, which is no longer necessary now that we don't expect to be dealing with hard links. The calls in tests have been replaced with helpers that check file contents and file mode.

@vercel
Copy link

vercel bot commented Jun 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 4:29PM (UTC)

@gsoltis gsoltis marked this pull request as ready for review June 28, 2022 23:55
@gsoltis gsoltis force-pushed the gsoltis/no_hard_link branch from c3e8c18 to f353fbe Compare June 29, 2022 17:12
@gsoltis gsoltis changed the base branch from gsoltis/add_back_symlink_cache to main August 19, 2022 16:21
@gsoltis gsoltis marked this pull request as draft August 19, 2022 16:22
@gsoltis gsoltis force-pushed the gsoltis/no_hard_link branch from f353fbe to 8767d55 Compare August 19, 2022 20:30
@gsoltis gsoltis marked this pull request as ready for review August 19, 2022 20:38
@gsoltis gsoltis added pr: on hold Pull requests that are "on hold" and should not be merged and removed pr: work in progress labels Aug 19, 2022
@gsoltis gsoltis added pr: automerge Kodiak will merge these automatically after checks pass and removed pr: on hold Pull requests that are "on hold" and should not be merged labels Aug 25, 2022
@gsoltis gsoltis requested a review from a team as a code owner August 25, 2022 16:28
@kodiakhq kodiakhq bot merged commit 2c40f76 into main Aug 25, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/no_hard_link branch August 25, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants