Add back symlinks in fs cache #1453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
The experimental Nextjs feature |
chris-olszewski
approved these changes
Aug 18, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
Removes code for hard links, which wasn't being used. Removes `CopyOrLinkFile`, which means symlink handling needs to be pushed down to `CopyFile`, so `CopyFile` now handles symlinks (broken or otherwise). Caching behavior is unchanged from the base branch (See #1453). Also removes `SameFile`, which is no longer necessary now that we don't expect to be dealing with hard links. The calls in tests have been replaced with helpers that check file contents and file mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back some behavior from before #1354. The filesystem cache will save all symlinks, and restore non-broken symlinks to files. Symlinks to directories continue to get restored as empty directories. Still TBD what we're going to do with broken symlinks in the filesystem cache, they currently are not restored.
For reference: the http cache saves and restores all symlinks.