Better ESLint configuration examples #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
2398021 to
455e9f8
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3895d4e to
cbc4d65
Compare
cbc4d65 to
54b1fa2
Compare
df69180 to
63aa216
Compare
jaredpalmer
approved these changes
May 3, 2022
This was referenced May 3, 2022
jaredpalmer
pushed a commit
that referenced
this pull request
May 3, 2022
|
@nathanhammond Can you please explain how does |
|
@AbdallahAbis Check out ESLint's docs on shareable configurations: https://eslint.org/docs/developer-guide/shareable-configs |
|
@nathanhammond Thank you! just figured that out and was going to update my comment, but you already answer. thanks for the fast reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
eslintconfigurations in examples were not actually relying on theeslint-recommended approach to sharing configurations and were instead directly requiring files. This switches the approach to what ESLint would recommend.Originally detected by @darrylblake in #1151, this corrects all of our examples.