fix: set eslint config to "root" inside examples #1151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darrylblake is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Prevents ESlint from referencing parent config and dependencies causing linting to fail if they've not been installed.
4f270eb to
1eb825b
Compare
|
Hey @darrylblake! Thanks for drawing my attention to an issue with our examples. The The method you've proposed to resolve the issues you were seeing tipped me off to that issue because it required setting Thank you so much for an actionable error report! |
kodiakhq bot
pushed a commit
that referenced
this pull request
May 3, 2022
Our `eslint` configurations in examples were not actually relying on the `eslint`-recommended approach to sharing configurations and were instead directly requiring files. This switches the approach to what ESLint would recommend. Originally detected by @darrylblake in #1151, this corrects all of our examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents ESlint from referencing parent config and dependencies causing linting to fail if they've not been installed.