这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: adjust binary call for microfrontends proxy on Windows #10962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2025
Merged

fix: adjust binary call for microfrontends proxy on Windows #10962

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea3d46e
fix: use node to run microfrontends proxy on Windows
mknichel Oct 10, 2025
34dff52
Fix path->str
mknichel Oct 10, 2025
8222c92
use cfg!(windows)
anthonyshew Oct 15, 2025
4729a3f
WIP bdf71
anthonyshew Oct 15, 2025
7499203
WIP b1ddd
anthonyshew Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/turborepo-lib/src/task_graph/visitor/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,16 @@ impl<'a, T: PackageInfoProvider> CommandProvider for MicroFrontendProxyProvider<
let mut args = vec!["proxy", mfe_path.as_str(), "--names"];
args.extend(local_apps);

// On Windows, a package manager will rework the binary to be a .cmd extension
// since that's what Windows needs
let bin_name = if cfg!(windows) {
"microfrontends.cmd"
} else {
"microfrontends"
};

// TODO: leverage package manager to find the local proxy
let program = package_dir.join_components(&["node_modules", ".bin", "microfrontends"]);
let program = package_dir.join_components(&["node_modules", ".bin", bin_name]);
let mut cmd = Command::new(program.as_std_path());
cmd.current_dir(package_dir).args(args).open_stdin();
cmd
Expand Down
Loading