fix: adjust binary call for microfrontends proxy on Windows #10962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anthonyshew
approved these changes
Oct 15, 2025
tknickman
approved these changes
Oct 15, 2025
Contributor
|
Thanks, @mknichel! Tried out the original proposal and it broke macOS, so I'm going to try a slightly different approach that only changes the semantics of the binary call on Windows. Let's see how that does. |
Contributor
|
The Windows failure seen in CI is not related to this branch. It can be observed on other branches as well. Merging past the failure; we will fix in another PR. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The microfrontends local development proxy fails to start on Windows because it runs into:
%1 is not a valid Win32 application. The issue is that Turborepo runs the.jsscript and relies on the shebang to be run correctly. That doesn't work on Windows. This PR changes the code to runnodewhich will work on Windows.Testing Instructions
In a microfrontends repository, such as https://github.com/vercel-labs/microfrontends-nextjs-app-multi-zone, run
pnpm turbo run devon Windows and ensure that it starts up.