-
Notifications
You must be signed in to change notification settings - Fork 2.1k
docs(run): correct --graph formats; remove incorrect default mention #10744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just because GH won't let me comment on the line I want:
The flag arg should probably be --graph <file name> since we expect a full file name, not just an extension e.g. --graph foo.png
| ### `--graph <file type>` | ||
| Default: `jpg` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to change the default to dot
Default: dot
### Description Follow ups to #10744. (I missed that the PR was set to automerge) ### Testing Instructions 👀
Summary
--graphdocs with actual supported formats in CLI: addmermaidanddotto the list, and drop outdated reference. Remove misleading default.Rationale
SUPPORTED_GRAPH_FILE_EXTENSIONS).jpg, which is not enforced by the CLI (no default extension; empty value prints DOT to stdout).Test plan
crates/turborepo-lib/src/cli/mod.rsand validation invalidate_graph_extension.