这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@anthonyshew
Copy link
Contributor

Summary

  • Align --graph docs with actual supported formats in CLI: add mermaid and dot to the list, and drop outdated reference. Remove misleading default.

Rationale

  • CLI validates extensions against: svg, png, jpg, pdf, json, html, mermaid, dot (SUPPORTED_GRAPH_FILE_EXTENSIONS).
  • Docs previously claimed a default of jpg, which is not enforced by the CLI (no default extension; empty value prints DOT to stdout).

Test plan

  • Confirmed enum in crates/turborepo-lib/src/cli/mod.rs and validation in validate_graph_extension.
  • Built docs locally to verify formatting of the updated section.

@anthonyshew anthonyshew requested a review from a team as a code owner August 8, 2025 02:17
@vercel
Copy link
Contributor

vercel bot commented Aug 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 3:49am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 3:49am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 3:49am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 3:49am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 3:49am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 3:49am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 3:49am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 3:49am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 3:49am

@turbo-orchestrator turbo-orchestrator bot added the area: docs Improvements or additions to documentation label Aug 8, 2025
@anthonyshew anthonyshew enabled auto-merge (squash) August 11, 2025 17:22
Copy link
Contributor

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because GH won't let me comment on the line I want:

The flag arg should probably be --graph <file name> since we expect a full file name, not just an extension e.g. --graph foo.png

### `--graph <file type>`
Default: `jpg`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to change the default to dot
Default: dot

@anthonyshew anthonyshew merged commit 1efcd57 into main Aug 11, 2025
35 checks passed
@anthonyshew anthonyshew deleted the fix/docs-graph-default branch August 11, 2025 20:00
anthonyshew pushed a commit that referenced this pull request Aug 12, 2025
### Description

Follow ups to #10744. (I missed that the PR was set to automerge)

### Testing Instructions

👀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants