ci: upgrade to Node.js 22 #10374
Merged
ci: upgrade to Node.js 22 #10374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anthonyshew
commented
Apr 23, 2025
| "packageManager": "pnpm@8.14.0", | ||
| "engines": { | ||
| "node": "20.x" | ||
| "node": "22.x" |
Contributor
Author
There was a problem hiding this comment.
I'm upgrading the engines in package.json. I don't know if this is contentious or not. I'm seeing multiple versions of CI around the repository so I'm not sure if we consider this value important or not.
Contributor
Author
There was a problem hiding this comment.
As it turns out, we should definitely be doing this. This is now our source of truth.
chris-olszewski
approved these changes
Apr 23, 2025
anthonyshew
commented
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading our repository to Node.js 22 by reducing our source of truth to the value in
package.json#engines.Notably, this PR also adds Node.js 22 to the JS package test matrix.
Testing Instructions
CI