这是indexloc提供的服务，不要输入任何密码
Skip to content

ci: upgrade to Node.js 22 #10374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 24, 2025
Merged

ci: upgrade to Node.js 22 #10374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cd42917
ci: Upgrade to Node.js 22
anthonyshew Apr 23, 2025
d26976a
WIP 19c8a
anthonyshew Apr 24, 2025
7f7f172
Merge branch 'main' into shew/e3e09
anthonyshew Apr 24, 2025
66b6f52
WIP aede8
anthonyshew Apr 24, 2025
b786fb9
Merge branch 'shew/e3e09' of https://github.com/vercel/turborepo into…
anthonyshew Apr 24, 2025
9f4c5de
WIP b0f2a
anthonyshew Apr 24, 2025
9440844
WIP e3e85
anthonyshew Apr 24, 2025
a07cb9b
WIP b5e46
anthonyshew Apr 24, 2025
ca58844
WIP 8824d
anthonyshew Apr 24, 2025
8a32de5
WIP 1a2e7
anthonyshew Apr 24, 2025
37f5aa0
Update .github/actions/setup-node/action.yml
anthonyshew Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/actions/examples-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ runs:
uses: ./.github/actions/setup-turborepo-environment
with:
github-token: "${{ inputs.github-token }}"
node-version: "22"

- name: Install Global Turbo
uses: ./.github/actions/install-global-turbo
Expand Down
3 changes: 2 additions & 1 deletion .github/actions/setup-node/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ inputs:
node-version:
description: "Node version to install"
required: false
default: "18"
Copy link
Contributor Author

@anthonyshew anthonyshew Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A default is no longer needed because we're defaulting to package.json#engines.


runs:
using: "composite"
Expand All @@ -27,6 +26,8 @@ runs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
# node-version-file is the default, but can be overridden using node-version
node-version-file: "package.json"
Copy link
Contributor Author

@anthonyshew anthonyshew Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sets the default for our CI by reading package.json#engines.

node-version: ${{ inputs.node-version }}
cache: pnpm

Expand Down
1 change: 0 additions & 1 deletion .github/actions/setup-turborepo-environment/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ inputs:
node-version:
description: Node version
required: false
default: "18"
Copy link
Contributor Author

@anthonyshew anthonyshew Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/vercel/turborepo/pull/10374/files#r2057505677


runs:
using: "composite"
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ jobs:
uses: actions/checkout@v4

- uses: ./.github/actions/setup-node
with:
node-version: 20

- name: Run link checker
run: cd docs/link-checker && pnpm run check-links
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ jobs:
uses: ./.github/actions/setup-node
with:
extra-flags: --no-optional
node-version: "20"

- name: Install Global Turbo
uses: ./.github/actions/install-global-turbo
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-js-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
node-version:
- 18
- 20
- 22
env:
TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
TURBO_TEAM: ${{ vars.TURBO_TEAM }}
Expand Down
12 changes: 4 additions & 8 deletions .github/workflows/turborepo-compare-cache-item.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@ jobs:
runs-on: ${{ matrix.os }}

steps:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 18
- name: Setup Node
uses: ./.github/actions/setup-node

- name: create-turbo
run: |
Expand Down Expand Up @@ -50,10 +48,8 @@ jobs:
runs-on: ${{ matrix.os }}

steps:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 18
- name: Setup Node
uses: ./.github/actions/setup-node

- name: create-turbo
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/turborepo-native-lib-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
node-version:
- 18
- 20
- 22
env:
TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
TURBO_TEAM: ${{ vars.TURBO_TEAM }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/turborepo-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ jobs:
uses: ./.github/actions/setup-turborepo-environment
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
node-version: "20"
- name: Install Global Turbo
uses: ./.github/actions/install-global-turbo
with:
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/turborepo-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ jobs:
uses: ./.github/actions/setup-turborepo-environment
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
node-version: "18.20.2"
node-version: "18.20.2" # TODO: Update integration tests with changed log output in Node.js 22

- name: Install Global Turbo
uses: ./.github/actions/install-global-turbo
Expand Down Expand Up @@ -187,7 +187,6 @@ jobs:
uses: ./.github/actions/setup-turborepo-environment
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
node-version: "18.20.2"

- name: Run cargo fmt check
run: |
Expand Down Expand Up @@ -220,7 +219,6 @@ jobs:
uses: ./.github/actions/setup-turborepo-environment
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
node-version: "18.20.2"

- name: Run cargo check
run: |
Expand Down Expand Up @@ -256,7 +254,6 @@ jobs:
uses: ./.github/actions/setup-turborepo-environment
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
node-version: "18.20.2"

- name: Run sccache-cache
uses: mozilla-actions/sccache-action@v0.0.6
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/turborepo-top-issues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20
- uses: ./.github/actions/setup-node
- run: corepack enable
- run: pnpm install
- name: "Get Top Issues"
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/update-examples-on-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version: 20
- uses: ./.github/actions/setup-node

- name: Upgrade corepack
shell: bash
Expand Down
1 change: 0 additions & 1 deletion .node-version
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@
},
"packageManager": "pnpm@8.14.0",
"engines": {
"node": "20.x"
"node": "22.x"
Copy link
Contributor Author

@anthonyshew anthonyshew Apr 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm upgrading the engines in package.json. I don't know if this is contentious or not. I'm seeing multiple versions of CI around the repository so I'm not sure if we consider this value important or not.

Copy link
Contributor Author

@anthonyshew anthonyshew Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it turns out, we should definitely be doing this. This is now our source of truth.

}
}
Loading