-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: mark type of flat config export to satisfy Linter.Config[] #10128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@cprussin is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
anthonyshew
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
chris-olszewski
added a commit
that referenced
this pull request
Mar 10, 2025
### Description #10128 broke linting. Not sure why linting didn't run?? https://github.com/vercel/turborepo/blob/main/.github/workflows/lint.yml#L9 ### Testing Instructions Ran locally since lints might not run on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs: triage
New issues get this label. Remove it after triage
pkg: turbo-eslint
eslint-config-turbo and eslint-plugin-turbo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
satisfies Linter.Config[]
after the flat config definition. This allows importing the config into other typescirpt configs without having type unification issues.Testing Instructions
N/A this is a pretty simple type fix