这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: mark type of flat config export to satisfy Linter.Config[] #10128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

fix: mark type of flat config export to satisfy Linter.Config[] #10128

merged 2 commits into from
Mar 10, 2025

Conversation

@cprussin
Copy link
Contributor

@cprussin cprussin commented Mar 10, 2025 •
edited
Loading

Description

Adds satisfies Linter.Config[] after the flat config definition. This allows importing the config into other typescirpt configs without having type unification issues.

Testing Instructions

N/A this is a pretty simple type fix

@cprussin cprussin requested a review from a team as a code owner March 10, 2025 04:59
@turbo-orchestrator turbo-orchestrator bot added needs: triage pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo labels Mar 10, 2025
@vercel
Copy link
Contributor

vercel bot commented Mar 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 2:08pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 2:08pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 2:08pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 2:08pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 2:08pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 2:08pm

@vercel
Copy link
Contributor

vercel bot commented Mar 10, 2025

@cprussin is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@cprussin cprussin changed the title Mark type of flat config export to satisfy FlatConfig[] fix: mark type of flat config export to satisfy FlatConfig[] Mar 10, 2025
@cprussin cprussin changed the title fix: mark type of flat config export to satisfy FlatConfig[] fix: mark type of flat config export to satisfy Linter.Config[] Mar 10, 2025
anthonyshew
anthonyshew approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anthonyshew anthonyshew enabled auto-merge (squash) March 10, 2025 15:27
@anthonyshew anthonyshew merged commit 2a94a2b into vercel:main Mar 10, 2025
34 of 37 checks passed
@chris-olszewski chris-olszewski mentioned this pull request Mar 10, 2025
Merged
chris-olszewski added a commit that referenced this pull request Mar 10, 2025
@chris-olszewski
fix(eslint): array type lints (#10139)
15621f7 
### Description

#10128 broke linting. Not sure
why linting didn't run??


https://github.com/vercel/turborepo/blob/main/.github/workflows/lint.yml#L9

### Testing Instructions

Ran locally since lints might not run on CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees

No one assigned

Labels

pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cprussin @anthonyshew