这是indexloc提供的服务，不要输入任何密码
Skip to content

chore: delete redundant glob watcher code #10075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

chore: delete redundant glob watcher code #10075

merged 1 commit into from
Mar 4, 2025

Conversation

@NicholasLYang
Copy link
Contributor

@NicholasLYang NicholasLYang commented Mar 3, 2025 •
edited
Loading

Description

Turns out this is a redundant implementation of glob watching that we left in the codebase (probably due to a bad merge). Since it's blocking #10024, let's delete it.

Testing Instructions

@vercel
Copy link
Contributor

vercel bot commented Mar 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:07pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:07pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:07pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:07pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:07pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:07pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:07pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:07pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:07pm

@NicholasLYang NicholasLYang force-pushed the nicholasyang/debug-windows-globwatcher branch from 6a6c363 to 78c783d Compare March 3, 2025 19:36
@NicholasLYang NicholasLYang force-pushed the nicholasyang/debug-windows-globwatcher branch from 78c783d to 0ccce7c Compare March 3, 2025 22:07
@NicholasLYang NicholasLYang changed the title debug windows globwatcher chore: delete redundant glob watcher code Mar 3, 2025
@NicholasLYang NicholasLYang marked this pull request as ready for review March 3, 2025 23:49
@NicholasLYang NicholasLYang requested a review from a team as a code owner March 3, 2025 23:49
@NicholasLYang NicholasLYang merged commit 237b4b9 into main Mar 4, 2025
40 of 41 checks passed
@NicholasLYang NicholasLYang deleted the nicholasyang/debug-windows-globwatcher branch March 4, 2025 15:41
@chris-olszewski chris-olszewski mentioned this pull request Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

1 more reviewer

@chris-olszewski chris-olszewski chris-olszewski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicholasLYang @chris-olszewski