这是indexloc提供的服务，不要输入任何密码
Skip to content

chore: update to Rust 1.85.0 #10024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

chore: update to Rust 1.85.0 #10024

merged 1 commit into from
Mar 5, 2025

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented Feb 22, 2025 •
edited
Loading

Description

Testing Instructions

@ognevny ognevny requested a review from a team as a code owner February 22, 2025 09:35
@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Feb 22, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:53am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:53am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:53am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:53am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:53am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:53am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:53am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:53am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:53am

@vercel Vercel
Copy link

vercel bot commented Feb 22, 2025

@ognevny is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ognevny
Copy link
Contributor Author

ognevny commented Feb 22, 2025

not migrating to edition 2024 because it requires lots of code/formatting changes

@ognevny ognevny changed the title chore: Update to Rust 1.85.0 chore: update to Rust 1.85.0 Feb 22, 2025
@ognevny
Copy link
Contributor Author

ognevny commented Feb 23, 2025

Windows test failure seems unrelated

thread 'globwatcher::test::watch_single_file' panicked at crates\turborepo-lib\src\globwatcher\mod.rs:684:9:
assertion `left == right` failed: expected one of the globs to have changed
  left: {}
 right: {"my-pkg/.next/next-file"}

NicholasLYang
NicholasLYang approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@NicholasLYang NicholasLYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@NicholasLYang NicholasLYang mentioned this pull request Mar 3, 2025
Merged
NicholasLYang added a commit that referenced this pull request Mar 4, 2025
@NicholasLYang
chore: delete redundant glob watcher code (#10075)
237b4b9 
### Description

Turns out this is a redundant implementation of glob watching that we
left in the codebase (probably due to a bad merge). Since it's blocking
#10024, let's delete it.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
@ognevny ognevny requested a review from chris-olszewski March 5, 2025 05:37
chris-olszewski
chris-olszewski approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. As @NicholasLYang discovered, the failing test was for dead code #10075. We're assuming there was a bug in that code that has been fixed in the moved variant of that code.

@chris-olszewski chris-olszewski merged commit efbb5e1 into vercel:main Mar 5, 2025
43 checks passed
@ognevny ognevny deleted the rust-1.85.0 branch March 5, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasLYang NicholasLYang NicholasLYang approved these changes

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
needs: triage New issues get this label. Remove it after triage pkg: turbo-repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ognevny @chris-olszewski @NicholasLYang