docs: fixing --no-cache alert #10653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@0ri0nexe is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
anthonyshew
requested changes
Jul 9, 2025
crates/turborepo-lib/src/cli/mod.rs
Outdated
| @@ -399,7 +399,7 @@ impl Args { | |||
| if run_args.no_cache { | |||
| warn!( | |||
| "--no-cache is deprecated and will be removed in a future major version. Use \ | |||
| --cache=local:r,remote:r" | |||
There was a problem hiding this comment.
This is the correct invocation to recommend. --no-cache would prevent writing, not reading.
This confusion is part of the reason we changed the API.
|
Hey, @0ri0nexe, thanks for this! We'll need to change the recommendation in the CLI back to how it was, but happy to merge in the docs update. |
unfixed --no-cache comment
|
My bad i really thought --no-cache didn't make any cache reading |
anthonyshew
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minimal contribution because the alert of --no-cache deprecation gave a wrong command to use now with newer versions
Testing Instructions
In a project with a recent enough version of turbo such as 2.5.4 :
turbo run build --no-cache
--> You'll receive the alert on the use of --no-cache