-
Notifications
You must be signed in to change notification settings - Fork 2.1k
docs: fixing --no-cache alert #10653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@0ri0nexe is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
| if run_args.no_cache { | ||
| warn!( | ||
| "--no-cache is deprecated and will be removed in a future major version. Use \ | ||
| --cache=local:r,remote:r" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the correct invocation to recommend. --no-cache would prevent writing, not reading.
This confusion is part of the reason we changed the API.
|
Hey, @0ri0nexe, thanks for this! We'll need to change the recommendation in the CLI back to how it was, but happy to merge in the docs update. |
unfixed --no-cache comment
|
My bad i really thought --no-cache didn't make any cache reading |
anthonyshew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, thank you!
Description
Minimal contribution because the alert of --no-cache deprecation gave a wrong command to use now with newer versions
Testing Instructions
In a project with a recent enough version of turbo such as 2.5.4 :
turbo run build --no-cache
--> You'll receive the alert on the use of --no-cache