fix(examples): with-svelte example TypeScript #10450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrors I tested it with VS Code and Helix Editor and with current config, all export/imports of files, for instance in index.ts config, will result in a false error reporting of "Module does not exist", it seems to be happening because of miss configuration.
…oject Previously tsconfig.json refered to a file that does not exist.
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
chris-olszewski
approved these changes
May 6, 2025
Contributor
chris-olszewski
left a comment
There was a problem hiding this comment.
Approving, but this still can result in failures if checking types before building
| @@ -1,15 +1,10 @@ | |||
| { | |||
| "extends": "@repo/typescript-config/svelte.json", | |||
| "extends": ["@repo/typescript-config/svelte.json", "./.svelte-kit/tsconfig.json"], | |||
Contributor
There was a problem hiding this comment.
.svelte-kit only gets generated after a build is run so running check-types before building will result in failure
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired by @DoctorRyner in #10437, a set of changes to make TypeScript work better for the
with-svelteexample.Testing Instructions
This set of changes works correctly in my editor.