这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(examples): with-svelte example TypeScript #10450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025
Merged

fix(examples): with-svelte example TypeScript #10450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd7e1a8
fix: replace @repo/ui/tsconfig.json for with-svelte template to fix e…
DoctorRainer May 3, 2025
2117e75
fix: error when running check-types script in with-svelte @repo/ui pr…
DoctorRainer May 6, 2025
7d4fef3
Fixes for TypeScript.
anthonyshew May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions examples/with-svelte/packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"dev": "svelte-package --watch --input=src",
"build": "svelte-package --input=src",
"dev": "svelte-kit sync && svelte-package --watch --input=src",
"build": "svelte-kit sync && svelte-package --input=src",
"lint": "eslint .",
"check-types": "svelte-check --tsconfig ./tsconfig.json"
},
Expand All @@ -31,6 +31,7 @@
"devDependencies": {
"@repo/eslint-config": "workspace:*",
"@repo/typescript-config": "workspace:*",
"@sveltejs/kit": "^2.20.0",
"@sveltejs/package": "^2.0.0",
"@sveltejs/vite-plugin-svelte": "^5.0.0",
"eslint": "^9.25.0",
Expand Down
10 changes: 10 additions & 0 deletions examples/with-svelte/packages/ui/svelte.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { vitePreprocess } from '@sveltejs/vite-plugin-svelte';

/** @type {import('@sveltejs/kit').Config} */
const config = {
// Consult https://kit.svelte.dev/docs/integrations#preprocessors
// for more information about preprocessors
preprocess: vitePreprocess()
};

export default config;
15 changes: 5 additions & 10 deletions examples/with-svelte/packages/ui/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
{
"extends": "@repo/typescript-config/svelte.json",
"extends": ["@repo/typescript-config/svelte.json", "./.svelte-kit/tsconfig.json"],
Copy link
Contributor

@chris-olszewski chris-olszewski May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.svelte-kit only gets generated after a build is run so running check-types before building will result in failure

"compilerOptions": {
"declaration": true,
"declarationMap": true,
"allowArbitraryExtensions": true
},
"include": [
"src"
],
"exclude": [
"node_modules",
"dist",
".svelte-kit"
]
}
"include": ["dist", "./src/**/*.svelte", "./src/**/*.ts"],
"exclude": ["node_modules", ".svelte-kit"]
}
3 changes: 3 additions & 0 deletions examples/with-svelte/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading