这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@colombod
Copy link
Member

@colombod colombod commented Sep 5, 2019

This PR contains notebooks to show functionalities of the Kernel and interesting applications. It relates to #408

Copy link
Collaborator

@LadyNaggaga LadyNaggaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the samples on my pc and get these convert type errors from 'XPlot.Plotly.Graph.Scatter[]' to 'XPlot.Plotly.Graph.Trace'
image
Wasn't the result meant to be convert from plot to histogram?

@colombod
Copy link
Member Author

colombod commented Sep 5, 2019

I followed the samples on my pc and get these convert type errors from 'XPlot.Plotly.Graph.Scatter[]' to 'XPlot.Plotly.Graph.Trace'
image
Wasn't the result meant to be convert from plot to histogram?

The problem here is related to type resolution bug that is reported in #345 and dotnet/roslyn#23123

@LadyNaggaga
Copy link
Collaborator

I followed the samples on my pc and get these convert type errors from 'XPlot.Plotly.Graph.Scatter[]' to 'XPlot.Plotly.Graph.Trace'
image
Wasn't the result meant to be convert from plot to histogram?

The problem here is related to type resolution bug that is reported in #345 and dotnet/roslyn#23123

Oh okay. Thoughts on removing this section before or linking to the issue in the sample ?

@@ -0,0 +1,27 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This samples looks good to share. Just need to make a tiny typo colelctions to collections.
image

@colombod colombod force-pushed the feature/notebook_examples branch 7 times, most recently from 6486286 to fffb897 Compare September 16, 2019 21:01
@colombod colombod force-pushed the feature/notebook_examples branch from fffb897 to 01891af Compare September 17, 2019 16:48
@colombod colombod changed the title WIP create notebook examples create notebook examples Sep 17, 2019



NotebookExamples/csharp/.ipynb_checkpoints/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<ItemGroup>
<PackageReference Include="FSharp.Compiler.Service" />
<PackageReference Include="Microsoft.CodeAnalysis" Version="3.2.1" />
<PackageReference Include="Microsoft.CodeAnalysis" Version="3.4.0-beta2-19467-02" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a central place you can put these version numbers, so they don't have to be updated in so many places?

}
],
"source": [
"//display(createdThisMonth.Select(i => new {i.CreatedAt, i.Title, State = i.State.StringValue, i.Number}));\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment needed?

}
],
"source": [
"//display(openByMonth);\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this comment be removed?

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants