-
Notifications
You must be signed in to change notification settings - Fork 563
create notebook examples #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LadyNaggaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem here is related to type resolution bug that is reported in #345 and dotnet/roslyn#23123 |
Oh okay. Thoughts on removing this section before or linking to the issue in the sample ? |
| @@ -0,0 +1,27 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6486286 to
fffb897
Compare
fffb897 to
01891af
Compare
|
|
||
|
|
||
|
|
||
| NotebookExamples/csharp/.ipynb_checkpoints/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make more sense to ignore any .ipynb_checkpoints directory?
See
https://github.com/github/gitignore/blob/eb14c04c3596082f0d16a543d54b1fe1608c6498/community/Python/JupyterNotebooks.gitignore#L5
https://github.com/github/gitignore/blob/c1faae44aebe587bbb90d60e21ca928e0116e8d4/Python.gitignore#L77
| <ItemGroup> | ||
| <PackageReference Include="FSharp.Compiler.Service" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis" Version="3.2.1" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis" Version="3.4.0-beta2-19467-02" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a central place you can put these version numbers, so they don't have to be updated in so many places?
| } | ||
| ], | ||
| "source": [ | ||
| "//display(createdThisMonth.Select(i => new {i.CreatedAt, i.Title, State = i.State.StringValue, i.Number}));\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment needed?
| } | ||
| ], | ||
| "source": [ | ||
| "//display(openByMonth);\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this comment be removed?
eerhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains notebooks to show functionalities of the Kernel and interesting applications. It relates to #408