Add --port option to dotnet try #246
Conversation
|
The approach followed above will not work in IIS. However the configuration that we have currently uses IIS express for hosted mode, hence this code path is not called in that case. |
9066f10 to
29e8433
Compare
|
|
|
|
||
| if (StartupOptions.Mode == StartupMode.Try) | ||
| { | ||
| var uri = new Uri(app.ServerFeatures.Get<IServerAddressesFeature>().Addresses.First()); |
There was a problem hiding this comment.
Can there be more than one?
There was a problem hiding this comment.
Since we are setting up in the Program.cs to use a single url, there will be only one here - https://github.com/dotnet/try/pull/246/files#diff-adcfc4b0634e7250308be781cbe69f63R146
rchande
left a comment
There was a problem hiding this comment.
Is there a way for us to have an ApiViaHttpTest for the auto port selection?
| command.AddOption(new Option( | ||
| "--port", | ||
| "Specify the port for dotnet try to listen on", | ||
| new Argument<int>())); |
There was a problem hiding this comment.
Type should probably be ushort, since that matches the sign/max value requirements.
I have added a unit test around the part that determines the urls |
If we are in tool mode and the user has specified a port, we will use it otherwise we will launch on an available open port.
ServerFeaturesproperty to know the url at which the application is running and then launch the browser on the same when we are in the try mode.