-
Notifications
You must be signed in to change notification settings - Fork 563
Hide scroll bar in iframe #1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| width: auto; | ||
| height: auto; | ||
| margin: 0; | ||
| overflow: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the content is sized correctly, I would think we shouldn't need to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's find some time to discuss.
|
@jwmunn does this change break something on Learning ? |
|
We should close this PR and take a different approach. The editor's API can be called directly by the host page and that's going to be more flexible than one-size-fits-all attempts to remedy this with CSS. |
Pull request was closed
|
@jonsequitur will you expose a setSize function on your API instead? I believe this change will resolve all editor overflow issues. Learn is facing the same issue: |
|
Who is the owner of the scroll bars? is it the iframe or the div inside? |
|
Let's move this discussion to the associated issue. |
#1198
Thanks @danzhu54 for the fix suggestion