这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ocallesp
Copy link
Contributor

@ocallesp ocallesp commented Jun 3, 2024

#1198

hideScrollBar

Thanks @danzhu54 for the fix suggestion

@ocallesp ocallesp requested a review from colombod June 4, 2024 00:02
@ocallesp ocallesp enabled auto-merge June 4, 2024 00:02
width: auto;
height: auto;
margin: 0;
overflow: hidden;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the content is sized correctly, I would think we shouldn't need to do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the issue is not in the content.
Here is the animated gif showing the behavior WITHOUT 'overflow: hidden'
ScrollBar

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's find some time to discuss.

@ocallesp ocallesp requested a review from jonsequitur June 4, 2024 00:32
@ocallesp
Copy link
Contributor Author

ocallesp commented Jun 4, 2024

@jwmunn does this change break something on Learning ?

@jonsequitur
Copy link
Contributor

We should close this PR and take a different approach. The editor's API can be called directly by the host page and that's going to be more flexible than one-size-fits-all attempts to remedy this with CSS.

@ocallesp ocallesp closed this Jun 4, 2024
auto-merge was automatically disabled June 4, 2024 17:01

Pull request was closed

@danzhu54
Copy link

danzhu54 commented Jun 4, 2024

@jonsequitur will you expose a setSize function on your API instead? I believe this change will resolve all editor overflow issues. Learn is facing the same issue:
image

@colombod
Copy link
Member

colombod commented Jun 4, 2024

Who is the owner of the scroll bars? is it the iframe or the div inside?

@colombod
Copy link
Member

colombod commented Jun 4, 2024

This is what I see:
The content of the iframe is bigger than the iframe:
image
the element with class monaco-editor is se to this the size 1245px X 839px in the style sheet (side effect of calling the layout code)

this is the iframe size :
image

and this is the actual size of the div
image

@jonsequitur
Copy link
Contributor

jonsequitur commented Jun 4, 2024

Let's move this discussion to the associated issue.

#1198 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants