这是indexloc提供的服务，不要输入任何密码
Skip to content

Added create command #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added create command #599

wants to merge 2 commits into from

Conversation

@jazzzz
Copy link
Contributor

@jazzzz jazzzz commented Jun 5, 2014

This allows app configuration before the first push (see #487).

@jazzzz jazzzz mentioned this pull request Jun 5, 2014
Closed
@AlJohri
Copy link
Contributor

AlJohri commented Jun 5, 2014

👍

ping @rhy-jot

ghost
ghost reviewed Jun 15, 2014
View reviewed changes
plugins/00_dokku-standard/commands Outdated
Copy link

@ghost ghost Jun 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? It looks like ENV creation is automatically handled by the config:set command

Copy link
Contributor Author

@jazzzz jazzzz Jun 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I will remove it.

@jazzzz
Copy link
Contributor Author

jazzzz commented Jun 16, 2014

I removed the useless touch

@motin
Copy link
Contributor

motin commented Oct 2, 2014

+1 ping @rhy-jot
We have used this patch in https://github.com/neam/dokku-host-provisioning for about 1.5 months now and it is just great not having to initiate builds that we now will fail without the correct config set, just to have to rebuild them with an empty amend commit directly after setting the config.

@kristofsajdak
Copy link
Contributor

kristofsajdak commented Oct 10, 2014

+1
This feature would be a really nice addition to Dokku

@josegonzalez
Copy link
Member

josegonzalez commented Oct 10, 2014

I haven't gone through pull requests yet, but will take a look at this soon!

@kristofsajdak
Copy link
Contributor

kristofsajdak commented Oct 12, 2014

Great, looking forward to it.

josegonzalez added a commit that referenced this pull request Nov 16, 2014
@josegonzalez
Create an apps core plugin.
4b94330 
This creates the following commands:

- apps
- apps:create <app>
- apps:destroy <app>

It also:

- makes `delete` an alias for `apps:destroy`
- adds confirmation to `apps:destroy`
- allows a developer to remove apps that have been created via apps:create but have not been deployed

Refs #87
Refs #543
Refs #586
Closes #599
Refs #655
Refs #656
Refs #685
Closes #757
@josegonzalez josegonzalez mentioned this pull request Nov 16, 2014
Merged
@josegonzalez
Copy link
Member

josegonzalez commented Nov 16, 2014

Just a note, I implemented this slightly differently in #759 to maintain compatibility with how heroku handles it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jazzzz @AlJohri @motin @kristofsajdak @josegonzalez