Add 'apps' command and fix nginx-vhost plugin default behavior #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ema Can you split this PR in two parts? -> |
plugins/00_dokku-standard/commands
Outdated
Contributor
There was a problem hiding this comment.
shall we call this urls? Then you can do url <app-name> for one url and urls for urls of all apps.
Contributor
There was a problem hiding this comment.
Apps makes more sense to me. You could xargs them together if you wanted/needed.
Contributor
Author
|
Hey guys! Sorry for the delay, I was on vacation with very little internet access. I have created a new PR for dokku-client. Thanks for your comments! |
josegonzalez
added a commit
that referenced
this pull request
Nov 16, 2014
This creates the following commands: - apps - apps:create <app> - apps:destroy <app> It also: - makes `delete` an alias for `apps:destroy` - adds confirmation to `apps:destroy` - allows a developer to remove apps that have been created via apps:create but have not been deployed Refs #87 Refs #543 Refs #586 Closes #599 Refs #655 Refs #656 Refs #685 Closes #757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
These patches introduce 'apps', a new dokku command to list existing applications. I have noticed that new commands added to plugins/00_dokku-standard/commands were ignored, thus the second patch to fix nginx-vhosts' plugin behavior.
Thanks!
Emanuele