Support config variables containing \n
#1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Awesome! Can you also add a test for this? |
Contributor
Author
|
Sure, if you promise me to get this merged 😛 |
Contributor
Author
|
@michaelshobbs I added a test case, the CI build is running right now. |
Contributor
Author
|
@michaelshobbs Everything passed. 🎉 |
Contributor
Author
|
@michaelshobbs Looks there is some issue somewhere else as well. Restarting an app causes the |
Contributor
Author
|
I debuged the issue I've seen and a plugin was also doing This PR against dokku is ready. |
Member
|
@michaelshobbs verify this and merge it please :) |
michaelshobbs
added a commit
that referenced
this pull request
Jun 24, 2015
Support config variables containing `\n`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the following command completely messes up an apps
ENVconfig file:With these changes, the config file will contain look like expected: