Support removing config variables that contain \n.
#1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegonzalez
added a commit
that referenced
this pull request
Sep 18, 2015
Support removing config variables that contain `\n`.
Member
|
Shit, I read the pr incorrectly. You didn't fully test unset, just getting the attribute. Mind making a pr for that? |
Contributor
Author
|
Aww, crap. I'm super sorry about that. I can prepare an updated test case, but only on Monday or the days after. I hope that's okay with you? |
Member
|
@arthurschreiber I took care of it in #1480. Thanks for this pr though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1245.