create config set/unset without restart. closes #908 #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @josegonzalez |
Member
Author
|
@josegonzalez fixed usage message |
Member
|
I actually thought about it more, and since it's being called by the external command, we should just use the external names (set/unset) as opposed to the actual. Can you revert that change? As well, add some docs to the |
Member
|
Once ^ is done, we can merge :) |
e9b489c to
6cb770b
Compare
Member
Author
|
Done and done. |
josegonzalez
added a commit
that referenced
this pull request
Mar 19, 2015
create config set/unset without restart. closes #908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creates
config:set-norestartandconfig:unset-norestartI did not include these in the help output deliberately as this functionality is not compliant with Heroku functionality and is intended for internal use by things like plugins.
refs #1009