-
-
Notifications
You must be signed in to change notification settings - Fork 2k
extract first port from Dockerfile and set config variable for use in deploy phase. closes #993 #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
plugins/00_dokku-standard/commands
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this trigger a ps:restart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I didn't see any issue because we guard against it on the first deploy.
Let me rework the config portion.
|
I'd kind of rather have an internal-only command that does this instead exposing it to the user. For two reasons.
|
|
Thats fine with me, something in common? That way plugins could still use it, but not users. |
|
My concern is that adding something like this to common exposes configuration management outside of the config plugin, which I don't think is so great. |
|
How about |
|
Well it wouldn't be able to wrap |
|
Works for me. |
|
ping @josegonzalez |
c72a229 to
767b45a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer! I wonder if there are other places we can use this pattern?
|
Merge once this passes :) Good work! |
extract first port from Dockerfile and set config variable for use in deploy phase. closes #993
uses
dokku config:setto store first Dockerfile port for use in deploy phasecloses #993