idea: not requiring image-extras #1461
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Here is where docker requires it in their install.sh. Might be worth us just installing their install into our install: |
Author
|
I don't know if that would cause any other problems, but yeah -- the underlying concern being "why should dokku require aufs if docker doesn't any more?" I'm not sure which is the right way to go about it, but custom-kernel options e.g. for Linode could still be mentioned in the hosting-provider-specific docs and linked to from the install page, as it's something that some users would really want. |
Member
|
Closing in favor of 1467. @mrluc can you check if the bootstrap.sh from that branch can be run directly on linode? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a thought experiment.
But adding
|| trueto the line that attempts to installlinux-image-extra-...would mean that dokku could run places with custom kernels, like Linode, by falling back to DeviceMapper. People who really want AUFS could use pv-grub and the StackScript (once a documentation tweak is made).Is that just a crazy idea? I know that DeviceMapper has worse performance for starting/stopping containers, but as AUFS isn't upstream, it seems like it might work