这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@josegonzalez
Copy link
Member

Also simplify deb-based installation everywhere.

No idea yet if any of this works. I'll be trying it over the next few days...

Closes #1295
Closes #1461

@KernelMadness
Copy link
Contributor

+1 to docker upgrade, in 1.8 they fixed annoying memory leak on log tail.
Currently it causes OOM to me.

@josegonzalez josegonzalez force-pushed the 1295-docker-engine branch 2 times, most recently from 67a41df to 978d34e Compare September 15, 2015 20:25
Also simplify deb-based installation everywhere.

Closes #1295
Closes #1461
@josegonzalez
Copy link
Member Author

@michaelshobbs can you give this a once over? I can't really fix the package-based installation without merging/building a 0.4.0 package, but it should work fine.

@michaelshobbs
Copy link
Member

How do you install a specific version of docker?

@josegonzalez
Copy link
Member Author

You can't. And the new docker repo uses a new package name.

@michaelshobbs
Copy link
Member

You absolutely can. It's inefficient but you can. I think we should allow for it like we did before with $DOCKER_VERSION.

$ curl -sSL https://get.docker.com/ | sh
$ dpkg -l | grep docker-engine
ii  docker-engine                       1.8.2-0~trusty                   amd64        Docker: the open-source application container engine
$ apt-cache madison docker-engine
docker-engine | 1.8.2-0~trusty | https://apt.dockerproject.org/repo/ ubuntu-trusty/main amd64 Packages
docker-engine | 1.8.1-0~trusty | https://apt.dockerproject.org/repo/ ubuntu-trusty/main amd64 Packages
docker-engine | 1.8.0-0~trusty | https://apt.dockerproject.org/repo/ ubuntu-trusty/main amd64 Packages
docker-engine | 1.7.1-0~trusty | https://apt.dockerproject.org/repo/ ubuntu-trusty/main amd64 Packages
docker-engine | 1.7.0-0~trusty | https://apt.dockerproject.org/repo/ ubuntu-trusty/main amd64 Packages
$ apt-get install docker-engine=1.7.0-0~trusty
$ dpkg -l | grep docker-engine
ii  docker-engine                       1.7.0-0~trusty                   amd64        Docker: the open-source application container engine

@josegonzalez
Copy link
Member Author

You want to peg us to a specific version?

@michaelshobbs
Copy link
Member

I think we should, no? So we can say dokku core 0.4.0 + official plugins run on docker version x.y.z but you can override that version with $DOCKER_VERSION when installing?

@josegonzalez
Copy link
Member Author

Then upgrading docker would reinstall dokku if you install via deb package, no?

@michaelshobbs
Copy link
Member

Can't we pin the deb dependency as well? I can take a swing at revising this PR if you want.

@josegonzalez
Copy link
Member Author

Sure, pin the dependency if you want. Can we leave it open to anything in the 1.8.x line?

Feel free to update the PR.

@michaelshobbs
Copy link
Member

It doesn't look like it's possible just with apt-get. We'd have to script around a bit. My thinking is that pinning would make troubleshooting a bit easier. Maybe not though? We weren't pinned before the 1.7.x change... I could be convinced it's not that big of a deal. Thoughts?

@michaelshobbs
Copy link
Member

I would still like to be able to specify a version. I'll update to allow that at least.

@tilgovi
Copy link
Contributor

tilgovi commented Sep 16, 2015

You can use apt-mark hold but then you won't get the patch updates.

@michaelshobbs
Copy link
Member

👍

This will allow developers to run an `upgrade` on existing installations without breaking because docker-engine isn't yet in their apt lists...

[ci skip]
josegonzalez added a commit that referenced this pull request Sep 16, 2015
Upgrade dokku installation to use docker-engine
@josegonzalez josegonzalez merged commit 1c53250 into master Sep 16, 2015
@josegonzalez josegonzalez deleted the 1295-docker-engine branch September 16, 2015 23:02
@apmorton
Copy link

FYI, for anyone trying to install v0.3.26 currently, you just need to manually install herokuish 0.0.1 as follows before the dokku package will install properly
apt-get install herokuish=0.0.1

@josegonzalez
Copy link
Member Author

Sorry about that, there was a snafu in releasing 0.4.0. We should be all good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade to latest docker 1.7.0

7 participants