-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Upgrade dokku installation to use docker-engine #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+1 to docker upgrade, in 1.8 they fixed annoying memory leak on log tail. |
67a41df to
978d34e
Compare
978d34e to
1e479c6
Compare
|
@michaelshobbs can you give this a once over? I can't really fix the package-based installation without merging/building a 0.4.0 package, but it should work fine. |
|
How do you install a specific version of docker? |
|
You can't. And the new docker repo uses a new package name. |
|
You absolutely can. It's inefficient but you can. I think we should allow for it like we did before with |
|
You want to peg us to a specific version? |
|
I think we should, no? So we can say dokku core 0.4.0 + official plugins run on docker version x.y.z but you can override that version with |
|
Then upgrading docker would reinstall dokku if you install via deb package, no? |
|
Can't we pin the deb dependency as well? I can take a swing at revising this PR if you want. |
|
Sure, pin the dependency if you want. Can we leave it open to anything in the 1.8.x line? Feel free to update the PR. |
|
It doesn't look like it's possible just with apt-get. We'd have to script around a bit. My thinking is that pinning would make troubleshooting a bit easier. Maybe not though? We weren't pinned before the 1.7.x change... I could be convinced it's not that big of a deal. Thoughts? |
|
I would still like to be able to specify a version. I'll update to allow that at least. |
|
You can use |
|
👍 |
This will allow developers to run an `upgrade` on existing installations without breaking because docker-engine isn't yet in their apt lists... [ci skip]
Upgrade dokku installation to use docker-engine
|
FYI, for anyone trying to install v0.3.26 currently, you just need to manually install herokuish 0.0.1 as follows before the dokku package will install properly |
|
Sorry about that, there was a snafu in releasing 0.4.0. We should be all good now! |
Also simplify deb-based installation everywhere.
No idea yet if any of this works. I'll be trying it over the next few days...
Closes #1295
Closes #1461