这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@nerg4l
Copy link
Contributor

@nerg4l nerg4l commented Nov 12, 2021

From slack:

there appears to still be an issue dokku network:set --global initial-network app-internal ! App name must begin with lowercase alphanumeric character, and cannot include uppercase characters, colons, or underscores it thinks that app-internal is an app name, where it's actually a network name

The problem caused by network.CommandSet which validates the appName with common.VerifyAppName. Before calling this method from the subcommands the appName is replaced with --global which isn't a valid app name. I applied the logic I saw in common.CommandPropertySet to skip the verification when the appName parameter is --global.

@josegonzalez josegonzalez merged commit f1b0be3 into dokku:master Nov 12, 2021
github-actions bot pushed a commit that referenced this pull request Nov 12, 2021
# History

## 0.26.6

Install/update via the bootstrap script:

```shell
wget https://raw.githubusercontent.com/dokku/dokku/v0.26.6/bootstrap.sh
sudo DOKKU_TAG=v0.26.6 bash bootstrap.sh
```

### Bug Fixes

- #4919: @nerg4l fix: do not validate global flag as an app name
- #4918: @josegonzalez Use netrc binary to properly release dokku client homebrew formula
@nerg4l nerg4l deleted the fix-network-global branch February 14, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants