fix: do not validate global flag as an app name #4919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From slack:
The problem caused by
network.CommandSetwhich validates theappNamewithcommon.VerifyAppName. Before calling this method from the subcommands theappNameis replaced with--globalwhich isn't a valid app name. I applied the logic I saw incommon.CommandPropertySetto skip the verification when theappNameparameter is--global.