Allow double quotes in config values #401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows usage of double quotes and other special characters in config values. Single quotes in values still won't work, but solving that would require complex escaping.
|
@mloughran Would you mind attacking this from a higher level so it would cover everything? #345 has some hints/tips in that regard |
Author
|
I haven't really got time to try implementing #345 I'm afraid. It certainly looks related, but I haven't investigated sufficiently to be sure that it's the correct approach either, and this works for me for now. |
|
Isn't this a valid workaround until someone solves #345 ? |
Member
|
I've tested this against latest master both within the server and via ssh and it seems to work now that #702 has been merged. Closing, but thanks for working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if one wanted to store JSON in a config value (granted, not a great idea in general).
Setting
{"foo":"bar"}viassh -t ... config:set <app> TEST='{"foo":"bar"}'would result in the following (broken) line in ENV:With this pull request the value is strong quoted
For comparison, double quotes in config values do work on Heroku.
/cc @mdpye, thanks for the digging!