这是indexloc提供的服务,不要输入任何密码
Skip to content

Environment variables should be protected by single quotes #463

@myhro

Description

@myhro

Hi,

I was deploying a Django app, which reads his SECRET_KEY from the environment. I had no problem using config:set to set this variable, but if it contains special characters, like ), things just got messed up:

/app/.profile.d/app-env.sh: line 2: syntax error near unexpected token `)'
(...)    
django.core.exceptions.ImproperlyConfigured: The SECRET_KEY setting must not be empty.

If I manually add single quotes to this key value in the file /home/dokku/$APP/ENV, it works and not errors are shown.

I've tried to hack the config plugin, but haven't found where I could change this, so the value of the key would be saved in the ENV file surrounded by single quotes. I'm willing to send a patch if someone could help me to figure this out.

Regards,
Tiago.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions